Skip to content

Add captureTimestamp and senderCaptureTimeOffset to frame metadata - #228

Closed
Orphis wants to merge 1 commit into
w3c:mainfrom
Orphis:capture_timestamp
Closed

Orphis wants to merge 1 commit into
w3c:mainfrom
Orphis:capture_timestamp

Conversation

@Orphis

@Orphis Orphis commented May 2, 2024 •

Copy link
Copy Markdown

Fixes #225


Preview | Diff

@Orphis

Orphis commented May 2, 2024

Copy link
Copy Markdown
Author

@aboba Can we add this to the next interim's agenda please?

@aboba

aboba commented May 3, 2024

Copy link
Copy Markdown
Contributor

@Orphis Yes.

@dontcallmedom-bot

Copy link
Copy Markdown

This issue was mentioned in WEBRTCWG-2024-05-21 (Page 22)

Comment thread index.bs Outdated
Comment thread index.bs Outdated
@Orphis
Orphis force-pushed the capture_timestamp branch from 71a2372 to 740b9cf Compare June 19, 2024 15:11
Comment thread index.bs Outdated
@Orphis
Orphis force-pushed the capture_timestamp branch from 740b9cf to 1613039 Compare June 20, 2024 11:26
@Orphis
Orphis force-pushed the capture_timestamp branch from 1613039 to 1a211a1 Compare June 20, 2024 14:42

@jan-ivar jan-ivar left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR overall LGTM modulo a normative reference issue.

Comment thread index.bs
"title": "CloneArrayBuffer"
},
"RTP-EXT-CAPTURE-TIME": {
"href": "http://www.webrtc.org/experiments/rtp-hdrext/abs-capture-time",

@jan-ivar jan-ivar Jun 20, 2024 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This normative reference redirects to a googlesource link. I'll need to check with folks internally how to handle this.

Can we add a note mentioning any efforts to standardize this?

My understanding is after an IETF effort it would end up here?

@jan-ivar jan-ivar Jun 25, 2024 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See w3c/webrtc-extensions#216. I worry if we merge this it creates a blocker for advancement.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now have Harold’s draft (which will be up for adoption in IETF AVTCORE WG): https://datatracker.ietf.org/doc/draft-alvestrand-avtcore-abs-capture-time/

Comment thread index.bs
sequence<unsigned long> contributingSources;
long long timestamp; // microseconds
unsigned long rtpTimestamp;
DOMHighResTimeStamp captureTimestamp;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to captureTime for consistency with rVFC and others.

Comment thread index.bs
"title": "CloneArrayBuffer"
},
"RTP-EXT-CAPTURE-TIME": {
"href": "http://www.webrtc.org/experiments/rtp-hdrext/abs-capture-time",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"href": "http://www.webrtc.org/experiments/rtp-hdrext/abs-capture-time",
"href": "https://www.webrtc.org/experiments/rtp-hdrext/abs-capture-time",

@jan-ivar

jan-ivar commented Dec 5, 2024

Copy link
Copy Markdown
Member

Editors can integrate pending the adoption of https://datatracker.ietf.org/doc/draft-alvestrand-avtcore-abs-capture-time/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should we add captureTimestamp senderCaptureTimeOffset to the RTCEncodedXXXFrameMetadata if abs-capture-time is used?

7 participants